[Xcb] [PATCH proto xkb] Fixes for xkb.xml
Ran Benita
ran234 at gmail.com
Fri Feb 21 12:45:59 PST 2014
> From 73ce79a0dc9ee548b2c6716bb5a1a483246db80d Mon Sep 17 00:00:00 2001
> From: Christian Linhart <chris at DemoRecorder.com>
> Date: Fri, 14 Feb 2014 16:55:17 +0100
> Subject: [PATCH 4/5] xkb: reactivated union Doodad
>
> Reactivated union Doodad and its auxiliary structs and enums.
> Reason: The xml is OK as shown with another generator.
I don't if we had any problems with the actual XML. I suppose
uncommenting is fine, but I'm less eager here. It seemed pretty
difficult to get this stuff to work in *any* generator. If you can add
some test or such for this I'd be much happier :)
(same comment about the "broken").
Ran
> ---
> src/xkb.xml | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/xkb.xml b/src/xkb.xml
> index 3484c48..f038a08 100644
> --- a/src/xkb.xml
> +++ b/src/xkb.xml
> @@ -627,7 +627,6 @@ authorization from the authors.
> <item name="Logo"> <value>5</value> </item>
> </enum>
>
> - <!-- XXX: doodads are broken
> <struct name="CommonDoodad">
> <field name="name" type="ATOM" />
> <field name="type" type="CARD8" enum="DoodadType" />
> @@ -699,6 +698,7 @@ authorization from the authors.
> <field name="logo" type="LogoDoodad" />
> </union>
>
> + <!-- XXX: doodads are broken
> <struct name="Section">
> <field name="name" type="ATOM" />
> <field name="top" type="INT16" />
> --
> 1.7.2.5
>
More information about the Xcb
mailing list