[Xcb] [proto v2 1/3] xkb: Add missing modLatches as comment to LatchLockState

Peter Harris pharris at opentext.com
Thu Jul 17 13:55:57 PDT 2014


On 2014-07-17 16:49, Daniel Martin wrote:
> The field modLatches was missing in the request LatchLockState:
>     http://cgit.freedesktop.org/xorg/proto/kbproto/tree/XKBproto.h#n141
> 
> v2: Use a pad instead of a field, as the field would cause an API break.
>     Though, keep the field commented out to document it.
> 
> Signed-off-by: Daniel Martin <consume.noise at gmail.com>
> Reviewed-by: Peter Harris <pharris at opentext.com>

Uh, no. I never reviewed this version.

I'm still trying to decide if I want to NAK this version, because it
leaves LatchLockState broken (albeit slightly less broken than it used
to be).

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the Xcb mailing list