[Xcb] [proto v2 1/3] xkb: Add missing modLatches as comment to LatchLockState
Daniel Martin
consume.noise at gmail.com
Sat Jul 19 02:16:42 PDT 2014
On Thu, Jul 17, 2014 at 04:55:57PM -0400, Peter Harris wrote:
> On 2014-07-17 16:49, Daniel Martin wrote:
> > The field modLatches was missing in the request LatchLockState:
> > http://cgit.freedesktop.org/xorg/proto/kbproto/tree/XKBproto.h#n141
> >
> > v2: Use a pad instead of a field, as the field would cause an API break.
> > Though, keep the field commented out to document it.
> >
> > Signed-off-by: Daniel Martin <consume.noise at gmail.com>
> > Reviewed-by: Peter Harris <pharris at opentext.com>
>
> Uh, no. I never reviewed this version.
>
> I'm still trying to decide if I want to NAK this version, because it
> leaves LatchLockState broken (albeit slightly less broken than it used
> to be).
Have you made your decision: ack, nack or cancel? ;)
More information about the Xcb
mailing list