[Xcb] [proto v2 1/3] xkb: Add missing modLatches as comment to LatchLockState

[Daniel Martin]

On Mon, Jul 21, 2014 at 11:51:39AM -0400, Peter Harris wrote:
> On 2014-07-19 05:16, Daniel Martin wrote:
> > On Thu, Jul 17, 2014 at 04:55:57PM -0400, Peter Harris wrote:
> >> On 2014-07-17 16:49, Daniel Martin wrote:
> >>> The field modLatches was missing in the request LatchLockState:
> >>>     http://cgit.freedesktop.org/xorg/proto/kbproto/tree/XKBproto.h#n141
> >>>
> >>> v2: Use a pad instead of a field, as the field would cause an API break.
> >>>     Though, keep the field commented out to document it.
> >>>
> >>> Signed-off-by: Daniel Martin <consume.noise at gmail.com>
> >>> Reviewed-by: Peter Harris <pharris at opentext.com>
> >>
> >> Uh, no. I never reviewed this version.
> >>
> >> I'm still trying to decide if I want to NAK this version, because it
> >> leaves LatchLockState broken (albeit slightly less broken than it used
> >> to be).
> > 
> > Have you made your decision: ack, nack or cancel? ;)
> 
> Upon further reflection, this version isn't perfect, but it is an
> improvement, so I'm not going to NAK it.
> 
> I am still going to withdraw my Reviewed-By:, though.

Changed the commit message accordingly and added Rans R-b.