[Xcb] [proto v2 1/3] xkb: Add missing modLatches as comment to LatchLockState

[Peter Harris]

On 2014-07-19 05:16, Daniel Martin wrote:
> On Thu, Jul 17, 2014 at 04:55:57PM -0400, Peter Harris wrote:
>> On 2014-07-17 16:49, Daniel Martin wrote:
>>> The field modLatches was missing in the request LatchLockState:
>>>     http://cgit.freedesktop.org/xorg/proto/kbproto/tree/XKBproto.h#n141
>>>
>>> v2: Use a pad instead of a field, as the field would cause an API break.
>>>     Though, keep the field commented out to document it.
>>>
>>> Signed-off-by: Daniel Martin <consume.noise at gmail.com>
>>> Reviewed-by: Peter Harris <pharris at opentext.com>
>>
>> Uh, no. I never reviewed this version.
>>
>> I'm still trying to decide if I want to NAK this version, because it
>> leaves LatchLockState broken (albeit slightly less broken than it used
>> to be).
> 
> Have you made your decision: ack, nack or cancel? ;)

Upon further reflection, this version isn't perfect, but it is an
improvement, so I'm not going to NAK it.

I am still going to withdraw my Reviewed-By:, though.

In my fantasy land, xcb/proto would contain your original patch, and
somebody else would magically volunteer to add a mechanism to libxcb
that would override specific items[1] that libxcb wants to maintain API
and ABI compatible.

Back here in reality, I expect you'll apply this patch to your queue
with Ran's Reviewed-by, and I'll pull your queue without further comment.

Peter Harris

[1] For reference, most of my other generators have such a mechanism.
But that's because <valueparam> and <union> are nearly useless, not
because I have an API or ABI to worry about.
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866