[Xcb] [PATCH] dri2: Add notes on lists that should be linked to their length fields but are not.
Daniel Martin
consume.noise at gmail.com
Mon Jun 9 14:47:02 PDT 2014
We should keep track of such things,
Reviewed-by: Daniel Martin <consume.noise at gmail.com>
Do we need a Signed-off-by for the patch?
On Fri, May 30, 2014 at 09:37:14AM +0200, Robert Ancell wrote:
> ---
> src/dri2.xml | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/dri2.xml b/src/dri2.xml
> index 20d6649..3b4c12e 100644
> --- a/src/dri2.xml
> +++ b/src/dri2.xml
> @@ -133,7 +133,10 @@ authorization from the authors.
> <request name="GetBuffers" opcode="5">
> <field type="DRAWABLE" name="drawable" />
> <field type="CARD32" name="count" />
> - <list type="CARD32" name="attachments" />
> + <list type="CARD32" name="attachments">
> + <!-- The length field should be linked but we can't correct it without breaking API -->
> + <!-- <fieldref>count</fieldref> -->
> + </list>
> <reply>
> <pad bytes="1" />
> <field type="CARD32" name="width" />
> @@ -159,7 +162,10 @@ authorization from the authors.
> <request name="GetBuffersWithFormat" opcode="7">
> <field type="DRAWABLE" name="drawable" />
> <field type="CARD32" name="count" />
> - <list type="AttachFormat" name="attachments" />
> + <list type="AttachFormat" name="attachments">
> + <!-- The length field should be linked but we can't correct it without breaking API -->
> + <!-- <fieldref>count</fieldref> -->
> + </list>
> <reply>
> <pad bytes="1" />
> <field type="CARD32" name="width" />
> --
> 2.0.0.rc4
>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb
More information about the Xcb
mailing list