[Xcb] Bug 79808 - xcb_xv_query_adaptors

[Daniel Martin]

On Tue, Jun 10, 2014 at 02:15:24PM -0400, Peter Harris wrote:
> On 2014-06-09 11:55, Daniel Martin wrote:
> > Hi folks,
> > 
> > I just had a look at the bug. There needs to be an alignment pad
> > between the 2 list (name and formats). But, if we just add the padding
> > we end up with invalid C code as the generator doesn't handle it
> > correctly.
> > 
> > Therefore, we've to watch out for such conditions and generate differnt
> > code:
> >     [PATCH lib] Handle <pad align="n" /> between lists
> > That was the most simple hack I could think of. It doesn't cause any
> > other diffs then in the query_adaptors reply related functions.
> 
> I added <pad align>, so this is probably my fault. Thanks so much for
> fixing my bug.

I don't think that you've introduced the bug. It's just a code path that
didn't hit before. Well, the alignment pad didn't existed before, but
there might be even more of such paths with elements we support for a
long time.

Hmm, after a grep and a brief check of xkb.xml I saw that there's such a
case in the reply of GetMap and I wonder why this patch doesn't affect
it ... the mysterious nested paths of c_client.py.