[Xcb] Bug 79808 - xcb_xv_query_adaptors

[Peter Harris]

On 2014-06-09 11:55, Daniel Martin wrote:
> Hi folks,
> 
> I just had a look at the bug. There needs to be an alignment pad
> between the 2 list (name and formats). But, if we just add the padding
> we end up with invalid C code as the generator doesn't handle it
> correctly.
> 
> Therefore, we've to watch out for such conditions and generate differnt
> code:
>     [PATCH lib] Handle <pad align="n" /> between lists
> That was the most simple hack I could think of. It doesn't cause any
> other diffs then in the query_adaptors reply related functions.

I added <pad align>, so this is probably my fault. Thanks so much for
fixing my bug.

I "tested" this by re-running the generator and confirming that the diff
was empty (before applying the next patch). Pushed.

> Then we can simply fix the bug with a one-liner:
>     [PATH proto] xv: Add align. pad in struct AdaptorInfo

The spec doesn't say anything about padding here (and has the formats
before the name), but I've verified that this matches what the X.org
server sends. Also pushed.

Thanks again.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866