[Xcb] [PATCH] dri2: Mark list length field in GetBuffers request so generated code doesn't ask for length field twice

[Robert Ancell]

Thanks for the review. I've sent a follow up patch that suggests
noting in the XML that they should be linked but cannot be done
without breaking API.

On Sun, May 25, 2014 at 3:57 PM, Daniel Martin <consume.noise at gmail.com> wrote:
> On Sat, May 24, 2014 at 04:47:34PM -0700, Robert Ancell wrote:
>> ---
>>  src/dri2.xml | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/dri2.xml b/src/dri2.xml
>> index 20d6649..f850b5a 100644
>> --- a/src/dri2.xml
>> +++ b/src/dri2.xml
>> @@ -133,7 +133,9 @@ authorization from the authors.
>>    <request name="GetBuffers" opcode="5">
>>      <field type="DRAWABLE" name="drawable" />
>>      <field type="CARD32" name="count" />
>> -    <list type="CARD32" name="attachments" />
>> +    <list type="CARD32" name="attachments">
>> +      <fieldref>count</fieldref>
>> +    </list>
>>      <reply>
>>        <pad bytes="1" />
>>        <field type="CARD32" name="width" />
>> --
>
> I think we can't use the patch as it causes an API break. It removes the
> attachments_len argument from xcb_dri2_get_buffers() and there're major
> projects using the function (mesa, qt4, iceweasel, chromium, ...):
>     http://codesearch.debian.net/search?q=xcb_dri2_get_buffers
>
> Cheers,
>     Daniel