[Xcb] xinput: make ListInputDevices work, sumof with nested expr, ...

[Christian Linhart]

Hi Ran,

Thank you very much for reviewing.

I'll post the revised whole patchset in a new thread with your R-b added appropriately.

I'll not reorder or squash the patches because that would require more work and would increase the danger of introducing new bugs without additional benefit. ( But thanks for offering that possibility. )

Chris

P.S.: As to my indenting style inside expressions:
My default style is pretty simply to do the same indenting for all constructs,
such as expressions, statements, blocks.
That style was probably influenced by doing some LISP programming while at the university. :-)

In my proprietary code, this helps me focus on the programming
without much thinking about formatting, therefore increasing my productivity.

Anyways, I'll change it as per your suggestions as that matches the style better
and is probably better suited for Python anyways.

Sorry for not noticing the formatting stuff.
My thinking strengths are more overview / essential-stuff / networked / system-level / intuitive.
Attention to such detail is not really my strength, as you see ;-)
We complement each other quite well because you have a real talent for details.
Such complement of talent makes a good team.


On 11/01/14 11:56, Ran Benita wrote:
> Hi Chris,
>
> The entire series looks good to me (the libxcb patches and the proto
> ones which I had reviewed earlier), with just some minor comments.
>
> Can you post the revised patches in a new thread? This one is a bit
> messy.. Feel free to add my R-b. You can also reorder/squash the patches
> if you want.
>
> Ran
>
> On Wed, Sep 03, 2014 at 01:14:23PM +0200, Christian Linhart wrote:
>> Hi all,
>>
>> In this thread I'll post patches which make the ListInputDevice reply work.
>>
>> This has also required some changes in the generator:
>> * generate calls to accessor function or iterator function instead of
>>   a struct-member access for fields which can only be accessed with
>>   accessor function or iterator respectively.
>>
>> * make sumof more flexible. Especially support a nested expression which is evaluated
>>   in the scope of each list-element which is iterated to compute sumof.
>>   Example:
>>         <sumof ref="devices">
>>             <fieldref>num_class_info</fieldref>
>>         </sumof>
>>
>> Due to using switch-case, some structs have became obsolete.
>> (and due to using struct STR from xproto instead of DeviceName because these
>> are the same and the spec uses STR)
>>
>> This patchset contains two patches to remove these obsolete structs.
>> You may reject these patches due to API-compatibility concerns.
>> On the other hand, probably nobody has used the structs for request ListInputDevice
>> anyways before because this request/reply didn't work anyways in the previous form.
>>
>> You can also get these patches at the following git-repo:
>> http://infra-srv1.demorecorder.com/git/free-sw/xcb/listinputdevices-sumof-20140903-2/proto
>> http://infra-srv1.demorecorder.com/git/free-sw/xcb/listinputdevices-sumof-20140903-2/libxcb
>>
>> Chris
>>
>>
>> P.S.: The patches are based on the following patches which are not 
>> yet in the official repo:
>> * my patches from the the Thread 
>>   "[Xcb] xinput:QueryDeviceState: full-support: generator and xml-changes"
>> * my patch in the email 
>>   "[Xcb] [PATCH libxcb] no typename for nested structs"
>>
>> ( you can get those also at
>> http://infra-srv1.demorecorder.com/git/free-sw/xcb/20140903-1/proto
>> http://infra-srv1.demorecorder.com/git/free-sw/xcb/20140903-1/libxcb )
>>
>>
>> _______________________________________________
>> Xcb mailing list
>> Xcb at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/xcb
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb