[Xcb] [PATCH libxcb 01/18] c_client.py: remove unneeded call to get_serialize_params()

Christian Linhart chris at DemoRecorder.com
Mon Oct 13 08:09:40 PDT 2014


On 10/12/14 20:58, Ran Benita wrote:
> The results are not used, and the function doesn't have side effects.

It is always good to remove unneeded code.

Reviewed-by: Christian Linhart <chris at demorecorder.com>

> 
> Signed-off-by: Ran Benita <ran234 at gmail.com>
> ---
>  src/c_client.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/c_client.py b/src/c_client.py
> index 87f268b..51edda7 100644
> --- a/src/c_client.py
> +++ b/src/c_client.py
> @@ -739,7 +739,6 @@ def _c_serialize_helper_switch_field(context, self, field, c_switch_variable, pr
>      handle switch by calling _serialize() or _unpack(), depending on context
>      """
>      # switch is handled by this function as a special case
> -    param_fields, wire_fields, params = get_serialize_params(context, self)
>      field_mapping = _c_helper_field_mapping(self, prefix)
>      prefix_str = _c_helper_absolute_name(prefix)
>  



More information about the Xcb mailing list