[Xcb] [PATCH libxcb 00/18] Small improvements to the generator

[Ran Benita]

On Sun, Oct 12, 2014 at 10:54:34PM +0200, Rémi Cardona wrote:
> While I can't vouch for any of the "business logic" of xcb's codegen, I
> can review the Python bits:
> 
> Patch 1 through 16 are pythonically correct, so:
>   Reviewed-by: Rémi Cardona <remi at gentoo.org>
> (with a small nit for patch 10, see reply)

Thanks!

> Patch 11 touches Doxygen with which I'm no longer familiar, but it
> certainly looks OK.
> 
> As for the last 2:
> 
> Patch 18 is definitely not strictly identical to the previous code
> (though that does not mean it is wrong, just that someone else should
> look at it).

I have made silly mistakes before, but I think it is equivalent,
as in de morgan (just a bit easier to follow - hence the patch). Did I
miss something?

Ran

> Patch 17 is beyond my knowledge of xcb's internals.
> 
> Cheers,
> 
> Rémi