[Xcb] [PATCH libxcb 00/18] Small improvements to the generator

[Ran Benita]

On Wed, Oct 15, 2014 at 10:35:12PM +0200, Rémi Cardona wrote:
> Le 14/10/2014 13:48, Ran Benita a écrit :
> > I have made silly mistakes before, but I think it is equivalent,
> > as in de morgan (just a bit easier to follow - hence the patch). Did I
> > miss something?
> 
> No, it's just that the order is different. So the evaluation order is
> changed. If calling field.type.fixed_size() has no consequence on other
> attributes, then this indeed looks fine.
> 
> But Python being an overly dynamic language, this needs review by
> someone who knows the codegen's internals.

I see what you mean now. Yes, `fixed_size()` is pure. I swapped the
order because the new one looks more sensible to me - the `wire`
conditions is clearly the "main" condition here, followed by exceptions.

Ran

> Cheers,
> 
> Rémi
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb