[Xcb] [PATCH libxcb 14/18] c_client.py: remove commented debug statements

Christian Linhart chris at DemoRecorder.com
Sat Oct 25 08:57:26 PDT 2014


This just removes comments. Therefore the code remains the same.

Therefore:
Reviewed-by: Christian Linhart <chris at demorecorder.com>

It's good to get rid of these debug statements.
If something has to be debugged, appropriate debug statements can be entered anyways.
And they probably will be needed in different locations that the ones which are removed here.

Debug statements should be temporary anyways, unless some complex and useful stuff
has to be done there, in which case the complex stuff should be put in an extra function or class.


On 10/12/14 20:58, Ran Benita wrote:
> Signed-off-by: Ran Benita <ran234 at gmail.com>
> ---
>  src/c_client.py | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/c_client.py b/src/c_client.py
> index 1c77bb0..686eca5 100644
> --- a/src/c_client.py
> +++ b/src/c_client.py
> @@ -648,7 +648,6 @@ def get_serialize_params(context, self, buffer_var='_buffer', aux_var='_aux'):
>  def _c_serialize_helper_insert_padding(context, code_lines, space, postpone):
>      code_lines.append('%s    /* insert padding */' % space)
>      code_lines.append('%s    xcb_pad = -xcb_block_len & (xcb_align_to - 1);' % space)
> -#    code_lines.append('%s    printf("automatically inserting padding: %%%%d\\n", xcb_pad);' % space)
>      code_lines.append('%s    xcb_buffer_len += xcb_block_len + xcb_pad;' % space)
>  
>      if not postpone:
> @@ -1971,8 +1970,6 @@ def _c_request_helper(self, name, cookie_type, void, regular, aux=False, reply_f
>          _c('    unsigned int xcb_tmp_len;')
>          _c('    char *xcb_tmp;')
>      _c('')
> -    # simple request call tracing
> -#    _c('    printf("in function %s\\n");' % func_name)
>  
>      # fixed size fields
>      for field in wire_fields:



More information about the Xcb mailing list