[Xcb] [PATCH libxcb 13/18] c_client.py: use C99 initializers instead of comments

[Christian Linhart]

Sequence and names do match correctly as can be seen by comparing it
with the definition of xcb_protocol_request_t:
http://cgit.freedesktop.org/xcb/libxcb/tree/src/xcbext.h#n47

Therefore this does the same, however there may be another problem:

Is this the first instance in XCB which requires a C99-compliant compiler?

Intuitively it should be safe to assume that a C99 compliant compiler is available on all relevant platforms.

But I have one test computer which uses X11 and where this is not the case.
This test computer is from one of my customers and matches their production system ( at least somehow ).
XCB may become relevant on that computer.

This may be a hint that there are more users where pre-C99 compatibility can be relevant.

Chris

On 10/12/14 20:58, Ran Benita wrote:
> Signed-off-by: Ran Benita <ran234 at gmail.com>
> ---
>  src/c_client.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/c_client.py b/src/c_client.py
> index eab4006..1c77bb0 100644
> --- a/src/c_client.py
> +++ b/src/c_client.py
> @@ -1948,10 +1948,10 @@ def _c_request_helper(self, name, cookie_type, void, regular, aux=False, reply_f
>  
>      _c('{')
>      _c('    static const xcb_protocol_request_t xcb_req = {')
> -    _c('        /* count */ %d,', count)
> -    _c('        /* ext */ %s,', func_ext_global)
> -    _c('        /* opcode */ %s,', self.c_request_name.upper())
> -    _c('        /* isvoid */ %d', 1 if void else 0)
> +    _c('        .count = %d,', count)
> +    _c('        .ext = %s,', func_ext_global)
> +    _c('        .opcode = %s,', self.c_request_name.upper())
> +    _c('        .isvoid = %d', 1 if void else 0)
>      _c('    };')
>      _c('')
>