[Xcb] [PATCH libxcb 2/3] generator: support lists of structs which contain a switch

Ran Benita ran234 at gmail.com
Fri Sep 19 06:16:59 PDT 2014

Hi Chris,

On Fri, Sep 19, 2014 at 01:55:01PM +0200, Christian Linhart wrote:
> On 09/09/14 18:09, Ran Benita wrote:
> > On Thu, Aug 21, 2014 at 10:35:55PM +0200, Christian Linhart wrote:
> [...]
> >> Note:
> >> This patch also fixes a problem in the generator when
> >> a fixed-size list is the last field of a case or bitcase.
> > 
> > I'm not really qualified or have enough time to R-b this one, but from
> > what I can see all of these changes make sense and look good.
> Will it help when I explain this change in detail, 
> or shall I wait until somebody else reviews it?

The thing is, c_client.py is really hard to follow and understand,
particularly after support for switch-cases and other more difficult
stuff was added for xkb. And all of these things were added back then,
it seems, without much thought for maintainability (don't get me wrong
though - something is better than nothing!). So it requires a lot of
time to give a proper review, if you want to understand what's going on.

I will try to review your further changes, but I don't know when. I'm
really looking forward to having working xinput and complete xkb.
Hopefully an XCB dev will chime in and you can come up with a plan for
merging the changes.


> Chris

More information about the Xcb mailing list