[Xcb] [PATCH libxcb 1/1] Adding accessors for requests

[Christian Linhart]

Hi Jaya,

Thank you for your patch.
Adding "_c_accessors(self, name, name)" does the trick.
I have checked the diff of the generated code:
It does only add generated code. No existing generated code is removed.
Therefore this change is good. Well done!

Other than that, your patch is malformed:
* It does not apply cleanly with "git am".
   The patch looks like it is edited/created by hand instead of created with "git format-patch".

* The "+" before "_c_request_helper(self, name, 'xcb_void_cookie_t', True, True, True)" should not be there.
This line already exists.

Can you please create a well-formed patch and post it here?
( ideally relative to git.demorecorder.com because I'll merge that to upstream as soon as I get the issues with my new fd.o-account resolved.)

Regards,

Chris


On 01/22/15 18:16, Jaya Tiwari wrote:
> Added accessor functions for requests the same way they were added for structs,events and replies.
> Lists for replies have accessor functions now.
>
> Signed-off-by: Jaya Tiwari <tiwari.jaya18 at gmail.com <mailto:tiwari.jaya18 at gmail.com>>
> ---
>  src/c_client.py | 444 ++++++++++++++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 386 insertions(+), 58 deletions(-)
>
> diff --git a/src/c_client.py b/src/c_client.py
> index 56a1766..8a2900c 100644
> --- a/src/c_client.py
> +++ b/src/c_client.py
>
> @@ -3136,6 +3136,8 @@ def c_request(self, name):
>          _c_request_helper(self, name, 'xcb_void_cookie_t', True, True)
>          if self.c_need_aux:
>              _c_request_helper(self, name, 'xcb_void_cookie_t', True, False, True)
> +            _c_request_helper(self, name, 'xcb_void_cookie_t', True, True, True)
> +        _c_accessors(self, name, name)
>
>      # We generate the manpage afterwards because _c_type_setup has been called.
>      # TODO: what about aux helpers?
>
>
> -- 
> Regards,
> Jaya
>
>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20150207/5ea0e1da/attachment.html>