[Xcb] [Bug 90328] util-errors: out of tree builds do not work

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 5 23:19:00 PDT 2015


https://bugs.freedesktop.org/show_bug.cgi?id=90328

Uli Schlachter <psychon at znc.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Uli Schlachter <psychon at znc.in> ---
commit 5d660ebe872cadcdc85de9d6f9afe05de629c030
Author: Uli Schlachter <psychon at znc.in>
Date:   Wed May 6 08:10:53 2015 +0200

    Do not distribute extensions.c and fix out-of-tree builds

    It all started with src/extensions.c being distributed. Thanks to this,
tarballs
    shipped with this generated file and actually building this file was
skipped.
    Fix this by using the nodist_ variant of the SOURCES variable.

    Due to this oversight (sorry!), the out-of-tree build wasn't actually
tested.
    The rule that generates src/extensions.c was missing $(srcdir) in front of
the
    path to extensions.py. This rule is now fixed and, as suggested by Daphne
    Pfister, also changed to explicitly call the python interpreter. Configure
is
    changed to look for it.

    Finally, extensions.c couldn't include errors.h. This worked before,
because the
    C compiler automatically looks for headers in the same directory as the
source
    file. However, for out-of-tree builds, the source directory and build
directory
    are different. Paper over this problem by explicitly making it look in the
right
    directory.

    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=90328
    Signed-off-by: Uli Schlachter <psychon at znc.in>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20150506/a4e27565/attachment.html>


More information about the Xcb mailing list