[Xcb] [PATCH proto] xprint: Fix build of xprint extension

Olivier Fourdan ofourdan at redhat.com
Tue May 19 08:48:23 PDT 2015


Hi Peter,

> Since you're fixing the protocol definition of this request, you could
> also change the <!-- padding --> comment to <pad align="4" />. ("pad
> align" is relatively recent, and I'm guessing whoever originally wrote
> xprint.xml was too lazy to put in the annoyingly large <op> block
> required to do an alignment pad without "pad align").

If I add the <pad align="4" /> statement, the generated code won't build anymore :(

It fails with:

xprint.c: In function 'xcb_x_print_print_put_document_data_doc_format_end':
xprint.c:1338:36: error: 'None' undeclared (first use in this function)
     xcb_generic_iterator_t child = None;
                                    ^
xprint.c:1338:36: note: each undeclared identifier is reported only once for each function it appears in
xprint.c: In function 'xcb_x_print_print_put_document_data_options_end':
xprint.c:1362:36: error: 'None' undeclared (first use in this function)
     xcb_generic_iterator_t child = None;
                                    ^
Not sure why padding does that...

> That said, this looks good. With or without the <pad align="4" /> changes,
> Reviewed-by: Peter Harris <pharris at opentext.com>

Cheers!
Olivier


More information about the Xcb mailing list