[Xcb] [PATCH proto] xprint: Fix build of xprint extension

[Christian Linhart]

Hi Olivier,

Thank you for this patch.

This fixes the build issue and is a step in the right direction.

Therefore:
Reviewed-by: Christian Linhart <chris at demorecorder.com>

Chris

P.S.: For getting the padding to work, we need to fix bugs or
implement unimplemented stuff in the generator.
I'll look at that later.

@Jaya: Do you have any idea what needs to be done to get "pad align" work with that request?


On 05/19/15 16:04, Olivier Fourdan wrote:
> Generated XCB code based on xprint.xml won't compile because the
> arguments do not match now that the accessor functions for requests are
> generated in libxcb.
>
> Fix the definition so that the arguments match and the generated C code
> for XPrint can compile.
>
> Note, XPrint support has been removed in the X server since 2008, so
> this is mostly cosmetic or even pedantic because XPrint is long gone.
>
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> ---
>  src/xprint.xml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/src/xprint.xml b/src/xprint.xml
> index dc23dd0..4da49b0 100644
> --- a/src/xprint.xml
> +++ b/src/xprint.xml
> @@ -178,9 +178,13 @@ authorization from the authors.
>              <fieldref>len_data</fieldref>
>          </list>
>          <!-- padding -->
> -        <list type="STRING8" name="doc_format" />
> +        <list type="STRING8" name="doc_format">
> +            <fieldref>len_fmt</fieldref>
> +        </list>
>          <!-- padding -->
> -        <list type="STRING8" name="options" />
> +        <list type="STRING8" name="options">
> +            <fieldref>len_options</fieldref>
> +        </list>
>      </request>
>  
>      <request name="PrintGetDocumentData" opcode="12">