[Xcb] Is SendRequest missing some padding?

[Christian Linhart]

Hi Alessandro,

Thank you for this patch.
The upcoming auto-align-check would not have found it because missing pads would not cause any primitive data-types larger than 8bits to be misaligned.

I have two requests for getting this patch to the official repo:
1. Can you please repost it in the usual format of posting patches:
    I.e., generated by "git format-patch",
    so that the subjectline of the mail is prefixed with [PATCH proto],
    and so that the patch is included in the main message.

    This helps the people on the mailinglist to easily recognize your post as a patch to be reviewed.

2. Can you please include an explanation,
    and a link to the spec or source code which shows
    that these fields really should be 4-byte aligned?

If you need help with any of these, please tell me.

Cheers,

Chris


On 08/31/15 14:17, Alessandro Arzilli wrote:
> Patch attached.
>
> Alessandro Arzilli.
>
> On 08/15/2015 10:43 AM, Christian Linhart wrote:
>> Hi Alessandro,
>>
>> You are welcome.
>>
>> Yes, the missing align-pads will be added because I have an upcoming patch that automatically checks
>> for missing align-pads. Therefore, all missing align-pads will eventually get fixed.
>>
>> However, to be sure, you can post a patch to the xcb-mailinglist.
>> (make sure that your patch applies cleanly with "git am".)
>>
>> Chris
>>
>>
>> On 08/13/15 19:17, Alessandro Arzilli wrote:
>>> Thanks! Are the <pad align="4"/> tags going to get added to SetupRequest as well?
>>>
>>> On 08/13/2015 06:24 PM, Christian Linhart wrote:
>>>> Hi Alessandro,
>>>>
>>>> The patch for the problem which you have reported last September is now pushed to the official repo:
>>>> http://cgit.freedesktop.org/xcb/libxcb/commit/?id=4033d39d4da21842bb1396a419dfc299591c3b1f
>>>>
>>>> Sorry for the long time between posting my patch and pushing it.
>>>> (Back then I didn't have commit rights, yet. Later I forgot about that patch.)
>>>>
>>>> Thanks again for reporting that problem back then.
>>>>
>>>> Cheers,
>>>>
>>>> Chris
>>>>
>>>>
>>>> On 09/19/14 10:45, Christian Linhart wrote:
>>>>> Hi Alessandro,
>>>>>
>>>>> Thank you for checking that. Yes, you have checked out the correct branch.
>>>>>
>>>>> I'll look into this.
>>>>> Maybe it's easy to fix.
>>>>>
>>>>> Chris
>>>>>
>>>>> On 09/19/14 08:57, Alessandro Arzilli wrote:
>>>>>> On 09/18/2014 07:27 PM, chris at demorecorder.com wrote:
>>>>>>> Hello Alessandro,
>>>>>>>
>>>>>>> I think we should fix the problem in the generator with <pad align="4" />.
>>>>>>>
>>>>>>> Can you please try if <pad align="4" /> works with my newest patches which are not yet merged into upstream?
>>>>>>>
>>>>>>> You can get them with
>>>>>>> git clone http://infra-srv1.demorecorder.com/git/free-sw/xcb/libxcb/
>>>>>>> git clone http://infra-srv1.demorecorder.com/git/free-sw/xcb/proto/
>>>>>> I get the same error I got with libxcb-1.11.
>>>>>>
>>>>> [...]
>>>>> _______________________________________________
>>>>> Xcb mailing list
>>>>> Xcb at lists.freedesktop.org
>>>>> http://lists.freedesktop.org/mailman/listinfo/xcb
>>>>>
>>>>
>>>
>>
>
>
>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20150913/632ac670/attachment.html>