Menu Spec: including files & absolute paths

[Waldo Bastian]

On Monday 21 March 2005 11:22, Mark McLoughlin wrote:
> 	Okay, I tried, but I can't think of anything much better. What bothers
> me is that "parent" isn't an attribute of the tag's contents - i.e. it
> completely overrides the tag's content rather than giving information
> about the content. Also, <MergeFile merge_parent="false"/> makes no
> sense but <MergeFile merge_parent="true"/> does make sense.
>
> 	Perhaps it would be a tiny bit nicer if it was:
>
> <MergeFile type="parent">/etc/xdg/menus/applications.menu</MergeFile>
>
> 	because its more "I'm giving you a path, but I really want to merge the
> parent - if you know better how to do that, please do so".

Fine with me.

> 	Anyway, comments:
>
>   + As someone else pointed out - do you mean to bump the version to
>     1.0? Not that the version number really means anything :-)

I have another change related to menu-editing lined up, after that I think 1.0 
will be appropriate.

>   + s/the/this/ might make this sentence a bit more clear:
>
> -When the merge_parent attribute is set to "true" and the file that
> contains the <MergeFile> element 
> -When the merge_parent attribute is set to 
> "true" and the file that contains this <MergeFile> element

Ok.

>   + s/the filename specified in the tag/the contents of the tag/

Ok.

>   + The dtd needs to be updated too.

Good point. And it should be added to the website :-}

Attached patch ok?

Cheers,
Waldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: menu-spec-merge-parent.patch
Type: text/x-diff
Size: 5379 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xdg/attachments/20050321/1bb96097/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xdg/attachments/20050321/1bb96097/attachment.pgp