[PATCH] Fix generic case for xdg-terminal

Dan Nicholson dbn.lists at gmail.com
Wed Dec 13 01:02:42 EET 2006

xdg-terminal has a couple issues in the generic (xterm) case. First,
the `which' command setting terminal_exec will always be empty because
stdout is being redirected to /dev/null. Second, the command is never
actually attempted to be executed.

Attached patch fixed this issue with xterm, at least for a simple
functional test. -e is needed for the argument passing case. This
works on xterm, but I don't know about other terminal emulators.
Perhaps xterm should just be hard-coded for the generic case.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: generic-term.diff
Type: text/x-patch
Size: 776 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xdg/attachments/20061212/485ca6e0/attachment.bin 

More information about the xdg mailing list