Trash spec on FreeDesktop.org

[David Faure]

On Saturday 03 June 2006 03:46, Mikhail Ramendik wrote:
> When it was developed, no implementations existed. I remember some talks about 
> adding a description of recommenrded security checks, but I could not make 
> out a clear approach (perhaps it was just me...) so I really hoped to update 
> it after implementation, and to make sure everything including secutrity 
> checks is described as implemented.
> 
> David and Alexander - could you perhaps send me the particular source files 
> that deal with moving a file to the trash in KDE and Gnome? I'll try to 
> understand how things work. Or even better - if you have the time - could you 
> please compare the implementation to the specs, so that the specs could be 
> updated with the implementation details including security?

The KDE implementation of the trash spec is available at
http://websvn.kde.org/trunk/KDE/kdebase/runtime/kioslave/trash/trashimpl.cpp?view=auto

The security checks are implemented in the TrashImpl::trashForMountPoint method,
and I would definitely like a review of that code :)
TrashImpl::initTrashDirectory is also security-relevant.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).