Proposed draft for the thumbnail D-Bus specification

[Philip Van Hoof]

On Sun, 2008-09-07 at 13:47 +0200, Mikkel Kamstrup Erlandsen wrote:
> Just did a quick review of the Thumbnailer spec on
> http://live.gnome.org/ThumbnailerSpec as of today. Overall it seems
> good, but I have a few comments+questions.
> 
>  * It took me two reads to grok the interplay between Queue and
> Unqueue. It is elegant I give you that, but it could be explained
> better.

Added some documentation. Feel free to propose more documentation based
on your understanding of the elegance of the current solution.

>  * Why do each specialized thumbnailer has its own interface name? Ie
> com.mikkel.Thumbnailer? Since the interface is defined by the
> thumbnailer spec anyway, why is the name not? Calling it
> org.freedesktop.ThumbnailFactory or something would be more consistent
> imho.
> 

This is fixed to this:

org.freedesktop.thumbnailer.Generic      Generic thumbnailer's interface
org.freedesktop.thumbnailer.Thumbnailer  Specialized thumbnailer's interface

Specialized thumbnailers only specify their path and name, not their
interface. The class must implement o.f.thumbnailer.Thumbnailer

>  * Under which circumstances does the methods throw errors and when do
> they silently fail?
>   - What happens if I Queue the file "$£@2345234.$£"?
>   - Unqueuing a non-exisitng handle is probably not worth throwing
> errors for, but should be noted

Unfixed atm waiting for your input

>  * Which URI schemes are supported? Can I thumbnail web pages? Perhaps
> there should be some introspection for this (both in the generic
> thumbnailer and the specialized ones).

Working on this as we speak. Taking into account your input.

> Other than that good work! Cheers,

Thanks!

-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be