[Bug 1737] New: Suggest changing __CYGWIN__ test in fb.h

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 29 18:50:15 PDT 2004

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
           Summary: Suggest changing __CYGWIN__ test in fb.h
           Product: xorg
           Version: CVS_head
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: DDX/cygwin
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: torrey at mrcla.com
                CC: ago at freedesktop.org

I propose the following patch now that we have BuildRootless and the ROOTLESS define is defined for a 
rootless build on Cygwin and Mac OS X:

--- fb.h        11 Aug 2004 21:14:17 -0000      1.6
+++ fb.h        30 Oct 2004 01:45:15 -0000
@@ -647,7 +647,7 @@
        ((WindowPtr) (pWin))->devPrivates[fbGetWinPrivateIndex()].ptr)
-#if defined(__DARWIN__)||defined(__CYGWIN__)
+#ifdef ROOTLESS
 #define __fbPixOriginX(pPix)   ((pPix)->drawable.x)
 #define __fbPixOriginY(pPix)   ((pPix)->drawable.y)

This is correct on Darwin as only the rootless code relies on this although it was used for all Darwin 
builds. On non-rootless Darwin builds it had no noticeable effect. I believe the same is true on Cygwin. 
If Cygwin only needs this code to support the generic rootless layer, then we should apply this patch. If, 
Cygwin needs this code for some other purpose, we should probably change this to test for ROOTLESS 
or __CYGWIN__. Anyway, can some Cygwin guy tell me if this patch is correct?        
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the xorg-bugzilla-noise mailing list