[Bug 1424] Font rendering glitches with Render Acceleration enabled on radeon

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 4 07:46:56 PDT 2005


Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=1424          
     




------- Additional Comments From kem at freedesktop.org  2005-04-04 07:46 -------
(In reply to comment #63)
> Sorry, been busy for a while...
> 
> Kevin, if I read your patch in attachment 2178 [edit] correctly, this one
disables my
> patch but changes the texture size to 2^n *instead*. Am I right?

Partially correct.  It does disable your patch, but the texture size is actually
set to max(32,2^ceil(log2(width))).  Basically, it's just rounding the dst_pitch
up to the next power of two that completely contains the texture but makes sure
that the pitch is at least 32.

> Does this (together with the width/height setup) fix all problems? Then we might
> have stumbled over an alignment problem, and it could be enough to just use
> texture widths that are multiples of 8, 16 or 32. Maybe texture heights have to
> be equivalent, maybe not.

I had troubles with pitches less than 32, so that was why I made the minimum
texture width 32.  However, note that this was just for the second solution to
the problem (see comment #45 for details).  The first solution is the change to
tex_size = (height << 16) | width; which is the code path that is taken most
(all?) of the time.

Maybe I'm trying to explain too much in this patch.  I'll create two different
patches, each with their own solution.  That should help make the two different
solutions clearer.
          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


More information about the xorg-bugzilla-noise mailing list