[PATCH] Coverity Prevent: NO_EFFECT in EvdevWheelEmuSetProperty:

oliver.mcfadden at nokia.com oliver.mcfadden at nokia.com
Thu Jul 16 08:25:37 PDT 2009


From: Oliver McFadden <oliver.mcfadden at nokia.com>

Event unsigned_compare: Comparing unsigned less than zero is never true. "pEvdev->emulateWheel.timeout < 0UL"
342  	            if (pEvdev->emulateWheel.timeout < 0)
---
 src/emuWheel.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/src/emuWheel.c b/src/emuWheel.c
index bb3a980..a1c754d 100644
--- a/src/emuWheel.c
+++ b/src/emuWheel.c
@@ -337,15 +337,6 @@ EvdevWheelEmuSetProperty(DeviceIntPtr dev, Atom atom, XIPropertyValuePtr val,
                             16, PropModeReplace, 1,
                             &pEvdev->emulateWheel.inertia, TRUE);
             }
-
-            /* Don't enable with negative timeout */
-            if (pEvdev->emulateWheel.timeout < 0)
-            {
-                pEvdev->emulateWheel.timeout = 200;
-                XIChangeDeviceProperty(dev, prop_wheel_timeout, XA_INTEGER, 16,
-                        PropModeReplace, 1,
-                        &pEvdev->emulateWheel.timeout, TRUE);
-            }
         }
     }
     else if (atom == prop_wheel_button)
-- 
1.6.1



More information about the xorg-devel mailing list