[PATCH] pciaccess: remove xorg macros dependency

[Eric Anholt]

On Fri, 2009-07-17 at 02:05 +1000, Daniel Stone wrote:
> On Thu, Jul 16, 2009 at 08:27:12AM -0700, Eric Anholt wrote:
> > On Thu, 2009-07-16 at 14:18 +0300, Tiago Vignatti wrote:
> > > -m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2 or later before running autoconf/autogen])])
> > > -XORG_MACROS_VERSION(1.2)
> > >  AM_CONFIG_HEADER(config.h)
> > >  
> > >  # Check for progs
> > >  AC_PROG_CC
> > >  AC_PROG_LIBTOOL
> > > -XORG_CWARNFLAGS
> > >  
> > >  pciids_path=/usr/share/hwdata
> > >  AC_ARG_WITH(pciids-path, AC_HELP_STRING([--with-pciids-path=PCIIDS_PATH],
> > > @@ -108,9 +104,6 @@ AC_CHECK_MEMBER([struct pci_io.pi_sel.pc_domain],
> > >  AC_SUBST(PCIACCESS_CFLAGS)
> > >  AC_SUBST(PCIACCESS_LIBS)
> > >  		  
> > > -XORG_RELEASE_VERSION
> > > -XORG_CHANGELOG
> > > -
> > >  AC_OUTPUT([Makefile
> > >  	   src/Makefile
> > >             pciaccess.pc])
> > 
> > NAK.
> > 
> > Reducing the functionality of the package for no reason.
> 
> Agreed, but shouldn't XORG_RELEASE_VERSION be removed in general?

Yeah, XORG_RELEASE_VERSION is terrible, and I think XORG_CHANGELOG is
pretty bogus, too.  Removing the warning cflags is what I don't like.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20090729/2f078e86/attachment.pgp