xserver: Branch 'master' - 15 commits

Alan Coopersmith alan.coopersmith at sun.com
Mon Mar 16 08:42:56 PDT 2009


The casts of function returns to (void) were typically to silence
warnings from lint and similar source checkers that you were ignoring
the return values from the function, and really should be doing some
error checking there.   Not sure if those warnings are issued by
any of the source checkers currently used other than lint (gcc -Wall,
sparse, and Coverity are the other three I know of in use).

	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering

Peter Hutterer wrote:
> commit bfab422dcdbb9c009b2a91fe0dba288fac9bc859
> Author: Peter Hutterer <peter.hutterer at who-t.net>
> Date:   Fri Mar 13 16:27:49 2009 +1000
> 
>     xfixes: useless (void) typecast removal
>     
>     Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> diff --git a/xfixes/cursor.c b/xfixes/cursor.c
> index 3f26988..99403e5 100644
> --- a/xfixes/cursor.c
> +++ b/xfixes/cursor.c
> @@ -404,7 +404,7 @@ ProcXFixesGetCursorImage (ClientPtr client)
>  	swapl (&rep->cursorSerial, n);
>  	SwapLongs (image, npixels);
>      }
> -    (void) WriteToClient(client, sizeof (xXFixesGetCursorImageReply) +
> +    WriteToClient(client, sizeof (xXFixesGetCursorImageReply) +
>  			 (npixels << 2), (char *) rep);
>      xfree (rep);
>      return client->noClientException;




More information about the xorg-devel mailing list