[PATCH] Xi: don't crash when deleting invalid device properties.

Peter Hutterer peter.hutterer at who-t.net
Sun Nov 22 18:04:31 PST 2009

On Sun, Nov 22, 2009 at 05:57:25PM -0800, Keith Packard wrote:
> On Mon, 23 Nov 2009 10:35:56 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > +    if (!prop)
> > +        return BadAtom;
> > +
> Given that both callers convert BadAtom into Success, is there some
> reason not to just return Success here?

XIDeleteDeviceProperty can be called from other places (e.g. ptr
acceleration or a driver). For those it may be useful to know that the
property to be deleted did not exist on the device.
Right now it isn't, though I do have a patch here that calls it for ptraccel


More information about the xorg-devel mailing list