[PATCH] Xi: don't crash when deleting invalid device properties.

Keith Packard keithp at keithp.com
Sun Nov 22 18:21:59 PST 2009

On Mon, 23 Nov 2009 12:04:31 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> XIDeleteDeviceProperty can be called from other places (e.g. ptr
> acceleration or a driver).

Note that the matching function for window properties (DeleteProperty)
returns Success for missing properties currently; I'd suggest that the
device property API should do the same thing. (Alternatively, it should
probably return BadMatch as BadAtom has a very specific meaning (an
invalid atom was specified, not that the atom doesn't match a property)).

Given that this function hasn't ever been used outside of DIX, I'd say
making it do what DIX wants is a reasonable default. Any code caring
whether the property existed before deleting it can check separately.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091122/eb2079a5/attachment.pgp 

More information about the xorg-devel mailing list