[PATCH] Change xf86dga.h to only conditionally include server's header file.

Keith Packard keithp at keithp.com
Wed Sep 16 22:25:06 PDT 2009

On Thu, 2009-09-17 at 14:59 +1000, Peter Hutterer wrote:

> this is what I don't like about the whole approach - now you have the proto
> package include some libX* header although he protocol itself doesn't and
> shouldn't have any dependency on the library modules.

It's a backwards compatibility kludge necessitated because the proto
package used to ship with the xf86dga.h file including the library
symbols. With the goal of making the library symbols be part of the
library and not part of the protocol package, this seems to be a
reasonable compromise -- everyone keeps building, the library symbols
are defined in the library package and future versions of both server
and apps can be changed to use the correct file, instead of this
accidentally shared one.

> even more, if the server includes xf86dga.h without defining
> _XF86DGA_SERVER_ first, it now includes the library header. This just gets
> confusing. (I'm not sure there is a server version that actually does that,
> but still)

The server wouldn't have built in the past if it failed to define this,
so we can be pretty sure that didn't happen.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20090916/c9c95e9c/attachment.pgp 

More information about the xorg-devel mailing list