[PATCH] Change xf86dga.h to only conditionally include server's header file.

Carl Worth cworth at cworth.org
Thu Sep 17 09:05:55 PDT 2009


Excerpts from Peter Hutterer's message of Wed Sep 16 21:59:32 -0700 2009:
> this is what I don't like about the whole approach - now you have the proto
> package include some libX* header although he protocol itself doesn't and
> shouldn't have any dependency on the library modules.

Right. The protocold doesn't and shouldn't have any dependency on the
library.

But the include is an actual problem since the only things that depend
on the protocol package are either the X server or the library. And in
each case, that package will supply the file to be included. So
there's no sane case where the include-without-dependency can actually
cause a problem.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090917/455bfdf4/attachment.pgp 


More information about the xorg-devel mailing list