[PATCH] Change xf86dga.h to only conditionally include server's header file.
peter.hutterer at who-t.net
Fri Sep 18 00:54:09 PDT 2009
On Thu, Sep 17, 2009 at 09:05:55AM -0700, Carl Worth wrote:
> Excerpts from Peter Hutterer's message of Wed Sep 16 21:59:32 -0700 2009:
> > this is what I don't like about the whole approach - now you have the proto
> > package include some libX* header although he protocol itself doesn't and
> > shouldn't have any dependency on the library modules.
> Right. The protocold doesn't and shouldn't have any dependency on the
> But the include is an actual problem since the only things that depend
> on the protocol package are either the X server or the library. And in
> each case, that package will supply the file to be included. So
> there's no sane case where the include-without-dependency can actually
> cause a problem.
[sorry Carl, first email lost xorg-devel on cc]
I'm still not happy about this hack but I think it's good enough for this
case. I don't expect dgaproto to change much anymore, especially now that
its removal has been proposed.
ACK for both patches provided but please put the extra printf in to direct
clients that include xf86dga.h to Xxf86dga.h (as mentioned in my first
Note that a similar issue could be present for recordproto - see commit
b41dd4328bfb8a0981d299bb60f986a2bc55fd24. I'd be great if you could test
whether a similar fix is needed. The others should be fine.
More information about the xorg-devel