[PATCH 3/2] Track screens' installed colormaps as screen privates.

[Jamey Sharp]

On Thu, Apr 22, 2010 at 10:42 AM, Vignatti Tiago (Nokia-D/Helsinki)
<tiago.vignatti at nokia.com> wrote:
> On Thu, Apr 22, 2010 at 07:07:58PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote:
>> On Thu, Apr 22, 2010 at 07:34:04AM +0200, ext Jamey Sharp wrote:
>> > mi/micmap.c has the same pattern, except there the miInstalledMaps array
>> > is used in the xfree86 DDX, and I guess it's part of the server's ABI.
>> > So for now I left it alone.
>>
>> If we get cooked this and target to apply this before 1.9 merge window be
>> closed, so why bother? Even though, I removed this commentary from this patch
>> which seems unrelated.

I'm sorry, I didn't understand that. Do you mean it's OK to make ABI
changes for 1.9 so long as we get a bunch of them done at once and
remember to bump the ABI version?

> Well I did the same for micmap as well - look the attached.

Excellent. The bulk of the patch makes perfect sense to me. There are
a couple things I'd like to understand still though:

Since this adds and removes globals marked _X_EXPORT, it is an ABI
change, right? I'm still trying to work out what the rules are.

Does micmapScrPrivateKeyIndex need to be exported? AFAICT nothing
should ever refer to it except the initializer for
micmapScrPrivateKey, so it can be declared static, right?

Anyway,
Reviewed-by: Jamey Sharp <jamey at minilop.net>

Jamey