[PATCH 3/2] Track screens' installed colormaps as screen privates.

[Vignatti Tiago (Nokia-D/Helsinki)]

Hey Jamey,

On Fri, Apr 23, 2010 at 07:02:54AM +0200, ext Jamey Sharp wrote:
> On Thu, Apr 22, 2010 at 10:42 AM, Vignatti Tiago (Nokia-D/Helsinki)
> >>
> >> If we get cooked this and target to apply this before 1.9 merge window be
> >> closed, so why bother? Even though, I removed this commentary from this patch
> >> which seems unrelated.
> 
> I'm sorry, I didn't understand that. Do you mean it's OK to make ABI
> changes for 1.9 so long as we get a bunch of them done at once and
> remember to bump the ABI version?

Yeah, that what I meant... (see bellow)
 
> Excellent. The bulk of the patch makes perfect sense to me. There are
> a couple things I'd like to understand still though:
> 
> Since this adds and removes globals marked _X_EXPORT, it is an ABI
> change, right? I'm still trying to work out what the rules are.

probably yeah.


Please disregard any comment regarding ABI/API being break here. I didn't know
what I was talking previously, but I got already a feedback from some guys in
IRC.

 
> Does micmapScrPrivateKeyIndex need to be exported? AFAICT nothing
> should ever refer to it except the initializer for
> micmapScrPrivateKey, so it can be declared static, right?

you are right. I just amend it. 


Thanks,

                            Tiago