[PATCH libXi] fix build with gcc 2.95

[Mark Kettenis]

> Date: Fri, 27 Aug 2010 10:27:14 +1000
> From: Daniel Stone <daniel at fooishbar.org>
>
> On Thu, Aug 26, 2010 at 08:37:57AM +0200, Matthieu Herrb wrote:
> > On Wed, Aug 25, 2010 at 05:53:01PM -0400, Matt Turner wrote:
> > > Looks like a sufficiently trivial change, but what system still using
> > > gcc 2.95 does anyone care about running modern X.Org on?
> >=20
> > I have to repeat this every time I send a patch for gcc 2.95... :)=20
> 
> In fairness, it is rather unintuitive that an allegedly supported
> OS/architecture combination must have the absolute newest X server, yet
> hasn't managed to update its compiler in just over 11 years[0].

Well, GCC 2.95.3 was a pretty good C89 compiler[1], and apart from the
code/declaration interleaving issue, it supports all commonly used C99
features.  Later GCC versions are much, much slower, tend to have more
(or at least different) optimizer bugs, and don't really generate
significantly faster code.  It really is a problem if the build time
for the OpenBSD base systems goes up from a day to almost three days
on a SparcStation 20.

OpenBSD tries to deliver an OS that is conistent on all supported
architectures.  It's bad enough that we can't have the same C compiler
for all our platforms.  Besides, applications will require features
only available in newer X servers at some point.

Cheers,

Mark

[1] C++ support is a different matter though.