X Org server 1.7.99.2 is faulty

[Peter Dyballa]

Hello!

Following Jeremy Huddleston's advise I performed the bisecting and and  
invoke a "good" command when the compile X server was working OK and  
"bad" when it cut away text:

	pete 230 /\ git bisect good
	Bisecting: 38 revisions left to test after this (roughly 5 steps)
	[955b9f23a34cc79a5cd9676b45b3df4ffcc7302b] EXA:  
ModifyPixmapHeader_mixed fixes.
	pete 231 /\ git bisect good
	Bisecting: 19 revisions left to test after this (roughly 4 steps)
	[00a7252fe3e519e3e4d62cdd8746833ca59bce77] Fix dtrace object builds  
of libos to link with SHA1_LIBS
	pete 232 /\ git bisect bad
	Bisecting: 8 revisions left to test after this (roughly 3 steps)
	[d3e054ac07dae12a82ad764b0622fddbef4b9ec5] Merge remote branch  
'jeremyhu/master'
	pete 233 /\ git bisect good
	Bisecting: 4 revisions left to test after this (roughly 2 steps)
	[61335052972a78d67c0ba74f902273b34c63a198] Revert "Fix clipping when  
windows are used as sources"
	pete 234 /\ git bisect good
	Bisecting: 2 revisions left to test after this (roughly 1 steps)
	[a72c65e9176c51de95db2fdbf4c5d946a4911695] fb: Adjust transform or  
composite coordinates for pixman operations
	pete 238 /\ git bisect bad
	Bisecting: 0 revisions left to test after this (roughly 0 steps)
	[bd567061c8b84b268d9bbb01bc4d8981feefb862] Split fbGetDrawable into  
fbGetDrawablePixmap and fbGetPixmapBitsData
	pete 239 /\ git bisect good
	a72c65e9176c51de95db2fdbf4c5d946a4911695 is the first bad commit
	commit a72c65e9176c51de95db2fdbf4c5d946a4911695
	Author: Keith Packard <keithp at keithp.com>
	Date:   Wed Dec 2 08:37:20 2009 -0800
	
	    fb: Adjust transform or composite coordinates for pixman operations
	
	    Windows (or even pixmaps, in some cases) may not sit at the  
origin of
	    the containing pixmap, so any coordinates relative to the drawable
	    must be adjusted. For destinations and untransformed sources, the
	    operation coordinates are adjusted. For transformed sources, the
	    transform matrix is adjusted.
	
	    Signed-off-by: Keith Packard <keithp at keithp.com>
	    Acked-by: Soeren Sandmann <sandmann at daimi.au.dk>
	
	:040000 040000 41b3bb0dfe42bb68a703fb71ea3887bfcaad9159  
72836515ae5a3dece4eb25b63b92f9eda99a3e57 M	fb
	pete 240 /\ git bisect good
	a72c65e9176c51de95db2fdbf4c5d946a4911695 is the first bad commit
	commit a72c65e9176c51de95db2fdbf4c5d946a4911695
	Author: Keith Packard <keithp at keithp.com>
	Date:   Wed Dec 2 08:37:20 2009 -0800
	
	    fb: Adjust transform or composite coordinates for pixman operations
	
	    Windows (or even pixmaps, in some cases) may not sit at the  
origin of
	    the containing pixmap, so any coordinates relative to the drawable
	    must be adjusted. For destinations and untransformed sources, the
	    operation coordinates are adjusted. For transformed sources, the
	    transform matrix is adjusted.
	
	    Signed-off-by: Keith Packard <keithp at keithp.com>
	    Acked-by: Soeren Sandmann <sandmann at daimi.au.dk>
	
	:040000 040000 41b3bb0dfe42bb68a703fb71ea3887bfcaad9159  
72836515ae5a3dece4eb25b63b92f9eda99a3e57 M	fb
	
	pete 241 /\ git checkout -f master
	Previous HEAD position was bd56706... Split fbGetDrawable into  
fbGetDrawablePixmap and fbGetPixmapBitsData
	Switched to branch 'master'
	pete 242 /\ git pull --rebase
	remote: Counting objects: 211, done.
	remote: Compressing objects: 100% (121/121), done.
	Receiving objects: 100% (121/121), 19.38 KiB, done.
	remote: Total 121 (delta 102), reused 0 (delta 0)
	Resolving deltas: 100% (102/102), completed with 59 local objects.
	From git://anongit.freedesktop.org/xorg/xserver
	   9fad8f0..8d53d84  master     -> origin/master
	   d1320f4..8661189  server-1.7-nominations -> origin/server-1.7- 
nominations
	First, rewinding head to replay your work on top of it...
	Fast-forwarded master to 8d53d84485fdce8ea9686e6f300a69f7ddebd467.
	pete 243 /\ git revert a72c65e9176c51de95db2fdbf4c5d946a4911695
	Finished one revert.
	error: Terminal is dumb, but EDITOR unset
	Please supply the message using either -m or -F option.
	Exit 1
	pete 244 /\ setenv EDITOR emacsclient
	pete 245 /\ git revert a72c65e9176c51de95db2fdbf4c5d946a4911695
	fatal: Dirty index: cannot revert
	Exit 128
	pete 246 /\ git checkout -f master
	Already on 'master'
	pete 247 /\ git pull --rebase
	Current branch master is up to date.
	pete 248 /\ git revert a72c65e9176c51de95db2fdbf4c5d946a4911695
	Finished one revert.
	Waiting for Emacs...
	[master 8d7b130] Revert "fb: Adjust transform or composite  
coordinates for pixman operations"
	 3 files changed, 26 insertions(+), 58 deletions(-)

The last command created a buffer .git/COMMIT_EDITMSG with this  
contents:

	Revert "fb: Adjust transform or composite coordinates for pixman  
operations"
	
	This reverts commit a72c65e9176c51de95db2fdbf4c5d946a4911695.
	
	# Please enter the commit message for your changes. Lines starting
	# with '#' will be ignored, and an empty message aborts the commit.
	#
	# Committer: Peter Dyballa <Peter_Dyballa at Freenet.DE>
	#
	# On branch master
	# Changes to be committed:
	#   (use "git reset HEAD <file>..." to unstage)
	#
	#	modified:   fb/fb.h
	#	modified:   fb/fbpict.c
	#	modified:   fb/fbtrap.c
	#
	# Untracked files:
	#   (use "git add <file>..." to include in what will be committed)
	#
	#	compile.sh
	#	hw/xquartz/bundle/Info.plist

The X server compiled at this state works OK. So it seems that  
modifications to these three files broke the server. At least on Mac  
OS X 10.5.8 and big-endian PPC hardware and ATI RV360M11 graphics chip  
at AGP.

--
Greetings

   Pete

Work is the curse of the drinking class.
				– Oscar Wilde