pointer acceleration property rename and docs

Peter Hutterer peter.hutterer at who-t.net
Mon Jan 11 19:21:04 PST 2010


On Fri, Jan 08, 2010 at 04:55:28AM -0200, Fernando Carrijo wrote:
> On Fri, 8 Jan 2010 16:01:19 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > On Thu, Jan 07, 2010 at 11:28:38AM -0200, Fernando Carrijo wrote:
> > > On Thu, 07 Jan 2010 13:31:16 +0100, Simon Thum <simon.thum at gmx.de> wrote:
> > > > Hi,
> > > > 
> > > > here's some hopefully final embellishments.
> > > > 
> > > > Fernando, thanks for reviewing. If you wish a more formal attribution,
> > > > please send your reviewed-by tag.
> > > 
> > > I refrained from the idea of engraving a reviewed-by tag for believing
> > > that such a practice was reserved for those whose voices were louder
> > > than mine. Anyhow, here it goes...
> > > 
> > > Reviewed-by: Fernando Carrijo <fcarrijo at yahoo.com.br>
> > 
> > not really, if you reviewed it then you can state so. The definition of the
> > tag is:
> > "Reviewed-by: A Reviewed-by tag is a statement of opinion that the patch is
> > an appropriate modification of the kernel without any remaining serious
> > technical issues. Any interested reviewer (who has done the work) can offer
> > a Reviewed-by tag for a patch."
> >  
> > From http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches,
> > which itself is partially copied from the kernel's
> > Documentation/SubmittingPatches.
> > Bonus points for spotting which word needs to be replaced with "X Server".
> > 
> > Cheers,
> >   Peter
> > 
> 
> Hi Peter,
> 
> I've been lurking around for long enough to get somehow acquainted with
> the discussions regarding the meanings of s-o-b & friends. But even so,
> I use to feel kinda guilty for sending you busy people fixes as trivial
> as s/kernel/X Server/, followed or not by reviewed-by tags.
> 
> It's nice to know that you are open for those modest contributions.

Given that merging patches into master is now reliant on Reviewed-by tags
it's actually much appreciated to get more on those. There's plenty of
patches that are simple fixes and don't require extensive knowledge of the
surrounding code so those are easy targets for anyone who wants to take
them.

You'll notice that the more you review those, the more you get acquainted
with the code and the patches you can review become more complicated. Don't
be afraid to take the first step.
 
Cheers,
  Peter


More information about the xorg-devel mailing list