[PATCH resent 0/5] xfree86: vgaarb: clean up and device hidden

Mark Kettenis mark.kettenis at xs4all.nl
Thu Jun 3 02:29:46 PDT 2010

> From: Tiago Vignatti <tiago.vignatti at nokia.com>
> Date: Thu,  3 Jun 2010 11:34:09 +0300
> Please review. Thanks

Is it just me or are others also utterly confused by Tiago's diffs?
Let me explain what I mean:

> Tiago Vignatti (5):
>   xfree86: vgaarb: change macros by inline functions to ease debug

This diff makes VGAGet_GC and VGAPut_GC inline functions...

>   xfree86: vgaarb: remove superfluous and confusing VGAGet_GC and VGAPut_GC

...and then this diff removes them again.

It's this sort of thing that keeps confusing me (the fact that the
diffs end up arriving out of order in my mailbox doesn't make it
easier either).

If it is just me, I'll just keep my mouth shut after this.  But
otherwise I'd like to ask Tiago to spend a little bit more effort not
to create patch series that touch the same bit of code multiple times.

More information about the xorg-devel mailing list