[PATCH resent 0/5] xfree86: vgaarb: clean up and device hidden
dottedmag at dottedmag.net
Thu Jun 3 02:38:13 PDT 2010
Twas brillig at 11:29:46 03.06.2010 UTC+02 when mark.kettenis at xs4all.nl did gyre and gimble:
MK> Is it just me or are others also utterly confused by Tiago's diffs?
MK> Let me explain what I mean:
>> Tiago Vignatti (5):
>> xfree86: vgaarb: change macros by inline functions to ease debug
MK> This diff makes VGAGet_GC and VGAPut_GC inline functions...
>> xfree86: vgaarb: remove superfluous and confusing VGAGet_GC and VGAPut_GC
MK> ...and then this diff removes them again.
MK> It's this sort of thing that keeps confusing me (the fact that the
MK> diffs end up arriving out of order in my mailbox doesn't make it
MK> easier either).
MK> If it is just me, I'll just keep my mouth shut after this. But
MK> otherwise I'd like to ask Tiago to spend a little bit more effort
MK> not to create patch series that touch the same bit of code multiple
This way every patch is self-contained (and easily reviewed), which is
Good Thing. I'd be puzzled if first patch would convert every macros
_except two_ to inline functions, justified only by the next patch which
removes those two macros.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 835 bytes
Desc: not available
More information about the xorg-devel