[PATCH 2/2] xfixes: Use list.h macros in tracking hide count

Kristian Høgsberg krh at bitplanet.net
Mon Jun 14 08:48:54 PDT 2010

2010/6/14 Vignatti Tiago (Nokia-D/Helsinki) <tiago.vignatti at nokia.com>:
> On Mon, Jun 14, 2010 at 05:24:16PM +0200, ext Kristian Høgsberg wrote:
>>  I don't think it makes sense to go through the server and replace
>> existing linked list code.  That code is already written and tested,
>> and replacing it can only break stuff.
> I think open coded list implementation everywhere is more error prone than
> just have one single set of basic macros. Isn't it?

All the open coded lists in ther server are there now, and they're
working.  If it's not broken, don't mess with it.  If you come across
an error in an open coded list implementation, that would be a good
reason to port it to list.h.  But otherwise, you're just almost
certainly going to break working code.


More information about the xorg-devel mailing list