[PATCH 2/2] xfixes: Use list.h macros in tracking hide count

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Mon Jun 14 09:16:46 PDT 2010

On Mon, Jun 14, 2010 at 05:48:54PM +0200, ext Kristian Høgsberg wrote:
> 2010/6/14 Vignatti Tiago (Nokia-D/Helsinki) <tiago.vignatti at nokia.com>:
> >
> > I think open coded list implementation everywhere is more error prone than
> > just have one single set of basic macros. Isn't it?
> All the open coded lists in ther server are there now, and they're
> working.  If it's not broken, don't mess with it.  If you come across
> an error in an open coded list implementation, that would be a good
> reason to port it to list.h.  But otherwise, you're just almost
> certainly going to break working code.

I disagree with you Kristian.

Pick any code related with clean-up we had done recently; for instance the
replacement of the memory allocation function wrappers by the C89 ones. We can
say that they were "working", but this wouldn't be an argument to not remove.
If X would have a shiny code base and a driver API stable enough then I'd
agree with you to not touch. But you know we still have a way long to go to
achieve it. 

Seems that we're living in a era that Xorg project has more developers than
never [0], so the moment of clean up (including low-hanging fruits like this
list stuff) is right now.


[0] the traffic on xorg-devel on last months are _at_ _least_ 4 times higher
than one year ago.


More information about the xorg-devel mailing list