[RFC] xserver render: animated cursor state dynamically allocated

[Keith Packard]

On Tue,  4 May 2010 20:07:02 +0300, Tiago Vignatti <tiago.vignatti at nokia.com> wrote:
> Hi,
> 
> Let me know how this idea looks to you. It's a very messy code though and hard
> to review.
> 
> I haven't tested with several cursors, neither hotplug. But I don't see any
> apparent reasons why not work.
> 
> Probably we might want remove all private scheme and glue AnimCurStateRec in
> DeviceIntRec, given cursor is a always-in feature right now - well, shouldn't.
> We'll need to set some sort of AnimCursorFree if this idea sounds
> okay.

If DIX is going to unconditionally call the initialization function, we
might as well stick the pointer right in the
DeviceIntRec. Alternatively, we could add a callback list to be invoked
at EnableDevice time and have the animated cursor stuff hook onto that.

Also, AnimCursorAlloc must not call FatalError on allocation failure,
just return FALSE and then have that value handled in EnableDevice.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100504/8f1568d6/attachment.pgp>