[PATCH 1/3] render: removed unused macro from animcursor

Peter Hutterer peter.hutterer at who-t.net
Tue May 4 22:10:49 PDT 2010


On Tue, May 04, 2010 at 08:07:03PM +0300, Tiago Vignatti wrote:
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> ---
>  render/animcur.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/render/animcur.c b/render/animcur.c
> index 276e5e4..ab68aee 100644
> --- a/render/animcur.c
> +++ b/render/animcur.c
> @@ -98,7 +98,6 @@ static DevPrivateKey AnimCurScreenPrivateKey = &AnimCurScreenPrivateKeyIndex;
>  #define IsAnimCur(c)	    ((c) && ((c)->bits == &animCursorBits))
>  #define GetAnimCur(c)	    ((AnimCurPtr) ((c) + 1))
>  #define GetAnimCurScreen(s) ((AnimCurScreenPtr)dixLookupPrivate(&(s)->devPrivates, AnimCurScreenPrivateKey))
> -#define GetAnimCurScreenIfSet(s) GetAnimCurScreen(s)
>  #define SetAnimCurScreen(s,p) dixSetPrivate(&(s)->devPrivates, AnimCurScreenPrivateKey, p)
>  
>  #define Wrap(as,s,elt,func) (((as)->elt = (s)->elt), (s)->elt = func)
> @@ -375,7 +374,7 @@ AnimCursorCreate (CursorPtr *cursors, CARD32 *deltas, int ncursor, CursorPtr *pp
>      AnimCurPtr	ac;
>  
>      for (i = 0; i < screenInfo.numScreens; i++)
> -	if (!GetAnimCurScreenIfSet (screenInfo.screens[i]))
> +	if (!GetAnimCurScreen (screenInfo.screens[i]))
>  	    return BadImplementation;
>  
>      for (i = 0; i < ncursor; i++)
> -- 
> 1.6.0.4
 

I'd use the term "superfluous" rather than "unused", but that doesn't
matter much.

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
  Peter


More information about the xorg-devel mailing list