[PATCH 2/4] Rename region macros to mixed case and remove screen argument

Jamey Sharp jamey at minilop.net
Fri May 21 17:44:54 PDT 2010


On Fri, May 21, 2010 at 5:18 PM, Keith Packard <keithp at keithp.com> wrote:
> Very cool. Pushed.

I have one thing I'm still confused about before I give my reviewed-by
for the series. "Change region implementation from macros to inline
functions" has an assortment of renamings in region.c to remove the
"mi" prefix from various names. Most of those are visible in
regionstr.h. Did you intend to defer those that late or did you want
to get them moved back to "Move region implementation from mi to dix",
where those changes were in the first place?

I'm pretty sure that renaming miValidateTree to ValidateTree in a
region.c comment was just an accident, but I'm less convinced about
your intent for the rest.

Jamey


More information about the xorg-devel mailing list