[PATCH 2/4] Rename region macros to mixed case and remove screen argument

[Keith Packard]

On Fri, 21 May 2010 17:44:54 -0700, Jamey Sharp <jamey at minilop.net> wrote:

> I have one thing I'm still confused about before I give my reviewed-by
> for the series. "Change region implementation from macros to inline
> functions" has an assortment of renamings in region.c to remove the
> "mi" prefix from various names. Most of those are visible in
> regionstr.h. Did you intend to defer those that late or did you want
> to get them moved back to "Move region implementation from mi to dix",
> where those changes were in the first place?

Yeah, I should move those to the earlier mechanical patch, as you might
imagine, these changes were done within emacs to clean up the
un-exported symbols. I'll just add all of these symbols to the giant sed
script so they get cleaned up earlier.

> I'm pretty sure that renaming miValidateTree to ValidateTree in a
> region.c comment was just an accident, but I'm less convinced about
> your intent for the rest.

Yup, just an accident as I removed all of the 'mi' prefixes. I've fixed
that by explicitly renaming all of the private symbols in miregion.c and
regionstr.h in the 'fix-miregion-private' script and running that in the
first renaming patch. I also made the names 'EmptyBox' et al. less
ambiguous by adding 'Region' to their new names.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100522/5a7e09f9/attachment.pgp>