[PATCH 2/4] Rename region macros to mixed case and remove screen argument

Peter Harris pharris at opentext.com
Tue May 25 13:57:05 PDT 2010


On 2010-05-22 03:49, Keith Packard wrote:
> On Fri, 21 May 2010 17:44:54 -0700, Jamey Sharp <jamey at minilop.net> wrote:
> 
>> I'm pretty sure that renaming miValidateTree to ValidateTree in a
>> region.c comment was just an accident, but I'm less convinced about
>> your intent for the rest.
> 
> Yup, just an accident as I removed all of the 'mi' prefixes. I've fixed
> that by explicitly renaming all of the private symbols in miregion.c and
> regionstr.h in the 'fix-miregion-private' script and running that in the
> first renaming patch. I also made the names 'EmptyBox' et al. less
> ambiguous by adding 'Region' to their new names.

Stripping all the "mi" prefixes increases the likelihood of the names
colliding with someone else. In fact, "RectInRegion" collides with a
function of the same name in Win32. Can I talk you into renaming
"miRectIn" to something else?

Thanks,
 Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the xorg-devel mailing list