[PATCH v3 1/6] composite: Call ValidateGC after ChangeGC

[Jamey Sharp]

I don't see any on-list discussion about this question: Why does this
patch also switch from using serverClient to using NullClient?

Assuming that was intentional, I'd suggest a comment in the commit
message.

Jamey

On Fri, Apr 15, 2011 at 09:42:09PM +0300, ville.syrjala at nokia.com wrote:
> From: Ville Syrjälä <ville.syrjala at nokia.com>
> 
> ChangeGC changes the GC, so ValidateGC should be called after it, not
> before.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at nokia.com>
> Reviewed-by: Keith Packard <keithp at keithp.com>
> Reviewed-by: Adam Jackson <ajax at redhat.com>
> Reviewed-by: Daniel Stone <daniel at fooishbar.org>
> ---
> v3: unchanged
> 
>  composite/compalloc.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/composite/compalloc.c b/composite/compalloc.c
> index e4064f6..e840ee8 100644
> --- a/composite/compalloc.c
> +++ b/composite/compalloc.c
> @@ -562,9 +562,8 @@ compNewPixmap (WindowPtr pWin, int x, int y, int w, int h, Bool map)
>  	{
>  	    ChangeGCVal val;
>  	    val.val = IncludeInferiors;
> -	    
> +	    ChangeGC (NullClient, pGC, GCSubwindowMode, &val);
>  	    ValidateGC(&pPixmap->drawable, pGC);
> -	    ChangeGC (serverClient, pGC, GCSubwindowMode, &val);
>  	    (*pGC->ops->CopyArea) (&pParent->drawable,
>  				   &pPixmap->drawable,
>  				   pGC,
> -- 
> 1.7.3.4
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110415/1ccfb707/attachment.pgp>